Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTO force bug #369

Merged
merged 1 commit into from
Oct 8, 2024
Merged

PTO force bug #369

merged 1 commit into from
Oct 8, 2024

Conversation

jtgrasb
Copy link
Collaborator

@jtgrasb jtgrasb commented Sep 26, 2024

Description

Fixes two bugs identified by Issue #368:

  1. Corrects the force attribute in pto.post_process() from "Force or moment on WEC" to "PTO force or torque"
  2. Updates tutorial 1 to constrain the pto.force() rather than the pto.force_on_wec().

Type of PR

  • Bug fix

Checklist for PR

Additional details

N/A

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11061238892

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 94.583%

Totals Coverage Status
Change from base Build 10375743799: 0.07%
Covered Lines: 2776
Relevant Lines: 2935

💛 - Coveralls

@jtgrasb jtgrasb requested a review from dtgaebe September 26, 2024 23:04
Copy link
Collaborator

@dtgaebe dtgaebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@jtgrasb jtgrasb merged commit fa0b584 into sandialabs:dev Oct 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants