#12: remove BVH_ENABLE_KOKKOS macro
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cz4rs
force-pushed
the
12-remove-bvh-enable-kokkos-macro
branch
from
481a468
to
457afc9
Compare
|
The failing PR is because of the bottleneck in NimbleSM right now (NimbleSM/NimbleSM#355) |
nmm0
approved these changes
Dec 13, 2023
src/bvh/patch.hpp
Outdated
| #include <Kokkos_Core.hpp> | ||
| #endif | ||
|
|
||
| namespace bvh | ||
| { | ||
| #if 0 |
There was a problem hiding this comment.
Hmm, we probably should have removed this dead code a long time ago
There was a problem hiding this comment.
Removed the #if 0 block completely.
cz4rs
force-pushed
the
12-remove-bvh-enable-kokkos-macro
branch
2 times, most recently
from
4bcb99d
to
6e323e8
Compare
cz4rs
changed the title
BVH_ENABLE_KOKKOS macroBVH_ENABLE_KOKKOS macro
cz4rs
force-pushed
the
12-remove-bvh-enable-kokkos-macro
branch
from
6e323e8
to
70a9b4f
Compare
|
Can you rebase? I (finally)) merged the clustering branch |
cz4rs
force-pushed
the
12-remove-bvh-enable-kokkos-macro
branch
from
70a9b4f
to
9c337dd
Compare
nmm0
requested changes
Jan 25, 2024
src/bvh/hash.hpp
Outdated
|
|
||
| #if !defined(BVH_ENABLE_KOKKOS) || defined(KOKKOS_ACTIVE_EXECUTION_MEMORY_SPACE_HOST) | ||
| #if defined(KOKKOS_ACTIVE_EXECUTION_MEMORY_SPACE_HOST) |
There was a problem hiding this comment.
KOKKOS_ACTIVE_EXECUTION_MEMORY_SPACE_HOST was removed a while ago and I guess I forgot to remove it from here. I think the best bet is to change this to defined(__GNUC__) since I believe that will work for both gcc and clang host compilers.
There was a problem hiding this comment.
Replaced with __GNUC__ 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12