Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pu time increment call back into energy functions #70

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

btalamini
Copy link
Collaborator

@btalamini btalamini commented Nov 13, 2023

Small addendum to Craig's commit.

The dt argument was meant to stay as an optional argument to the mechanics functions. The intent was to pass a value in every time you call them, giving you the opportunity to use different values (say for adaptive time stepping). This isn't documented anywhere, so there wasn't a way for Craig to know that. There is an example in the app examples/uniaxial_dynamic/UniaxialDynamic.py.

The time interface is a little clunky, you can see how the project started with quasi-statics. We could consider adding the current time as an argument to the density functions (like dt is), which would make it easier to write time-dependent loads.

@cmhamel cmhamel merged commit d00ffd1 into sandialabs:main Nov 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants