Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FunctionSpace objects aware of whether they are axisymmetric #75

Merged

Conversation

btalamini
Copy link
Collaborator

When handed a FunctionSpace object, it can be useful to know if it does its calculus in axisymmetric coordinates or cartesian.

Copy link
Collaborator

@tupek2 tupek2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might consider moving away from namedtuples and use something like:

# data class
from chex._src.dataclass import dataclass
from chex._src import pytypes

@dataclass(frozen=True, mappable_dataclass=True)
class Polyhedral:
   interpolation : pytypes.ArrayDevice
   shapeGrad : pytypes.ArrayDevice
   weights : pytypes.ArrayDevice

Its easier to follow in code. No idea about the jit time. Also, that it is under chex._src is a bit odd.

@btalamini btalamini merged commit ea24f41 into sandialabs:main Dec 27, 2023
3 checks passed
@btalamini btalamini deleted the axisymmetric_functionspace_flag branch December 27, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants