Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gmres errors in CI triggered by new Scipy version #81

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Fix gmres errors in CI triggered by new Scipy version #81

merged 3 commits into from
Feb 28, 2024

Commits on Feb 27, 2024

  1. Fix GMRES solver errors in tests triggered in new scipy version 

    Scipy GMRES now modifies the preconditioned residual in place. This
is perfectly reasonable, but we were passing in jax numpy arrays,
which do not allow this. This was unsafe, but we got away with it.

This commit makes deep copies of jax arrays to plain numpy arrays
in the operators and initial data that the scipy gmres sees.
    @btalamini
    btalamini committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    3ac7026 View commit details
    Browse the repository at this point in the history

  2. Make logic for preconditioning choice simpler in Newton solver

    @btalamini
    btalamini committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    21b5f72 View commit details
    Browse the repository at this point in the history

  3. Fix conceptual error in GMRES tolerance specification 

    The relative tolerance for convergence was being set to a fraction
of the rhs norm, but the `tol` option is already a relative
tolerance.

This commit also fies a depracation warning, since the `tol`
parameter is deprecated in facor of `rtol`.
    @btalamini
    btalamini committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    6025ebd View commit details
    Browse the repository at this point in the history