Have nonlinear solvers output a success flag. This complicated custom vjp slightly. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btalamini
approved these changes
Mar 8, 2024
|
I actually didn't change the AlSolver, if has a runtime error if it doesnt converge. Also, most of the changes ended up being through the generic solver interface anyways. |
|
But, yes, the SPG and another one i didn't change yet. I can do that quickly, once I get these tests passing! |
…eally small compared to the tolerance. Previously, the penalty would just keep going up and up, and the constraint was already essentially fully enforced. This made the minimization problem too stiff. Have nonlinear solvers output a success flag. This complicated custom vjp slightly.
tupek2
force-pushed
the
SolverReturnsSuccessFlag
branch
from
4f1ae39
to
936291b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also do not increase the penalty when the constrain ncp error is already really small compared to the tolerance. Previously, the penalty would just keep going up and up, and the constraint was already essentially fully enforced. This made the minimization problem too stiff.