Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IV capabilities optional #90

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

kbonney
Copy link
Collaborator

@kbonney kbonney commented Nov 9, 2023

Description

IV related dependencies are moved to an installation extra.

Motivation and Context

IV capabilities are not used by every user, but come with very bulky dependencies (keras/tensorflow). By making IV optional, these dependencies are not installed by default.

How has this been tested? Documentation?

Testing workflows have been updated to install iv extra. A note is made in the IV module guide that the extra must be installed to use iv capabilities.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@kbonney kbonney merged commit a888c40 into sandialabs:master Nov 9, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant