Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: slimmed-down Levenberg-Marquardt for nonlinear least squares #500

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

WIP: slimmed-down Levenberg-Marquardt for nonlinear least squares #500

wants to merge 9 commits into from

Commits on Oct 18, 2024

  1. initial copy-paste of CustomLMOptimizer into SimplerLMOptimizer (and … 

    …copy-paste of custom_leastsq to simplish_lstsq)
    @rileyjmurray
    rileyjmurray committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    49d0c43 View commit details
    Browse the repository at this point in the history

  2. remove damping_mode; effectively hard-code it to damping_mode="identi… 

    …ty" in the CustomLSOptimizer behavior. Remove damping_clip as well, since that was only used for damping_mode != "identity".
    @rileyjmurray
    rileyjmurray committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    70044a5 View commit details
    Browse the repository at this point in the history

  3. remove damping_basis. Effectively hard-code it to get behavior of Cus… 

    …tomLMOptimizer when damping_basis=="diagonal_basis". I believe that since I already restricted damping_mode=identity in the previous commit that damping_basis has no special meaning anyway.
    @rileyjmurray
    rileyjmurray committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5fe6d11 View commit details
    Browse the repository at this point in the history

  4. remove straggler appearance of "damping_clip"

    @rileyjmurray
    rileyjmurray committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2365aa1 View commit details
    Browse the repository at this point in the history

  5. style

    @rileyjmurray
    rileyjmurray committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    16218c2 View commit details
    Browse the repository at this point in the history

  6. remove some comments. Identiffy blocks of code that need to be refact… 

    …ored out into their own functions
    @rileyjmurray
    rileyjmurray committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2722645 View commit details
    Browse the repository at this point in the history

  7. remove acceleration option

    @rileyjmurray
    rileyjmurray committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d5c6f0a View commit details
    Browse the repository at this point in the history

  8. remove minor lines

    @rileyjmurray
    rileyjmurray committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    45c5647 View commit details
    Browse the repository at this point in the history

  9. remove redundant class definitions. Keep the non-redundant definition… 

    …s in simplerlm.py instead of customlm.py, so we can mark the whole customlm.py file as deprecated.
    @rileyjmurray
    rileyjmurray committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1cdd821 View commit details
    Browse the repository at this point in the history