Revert "added a json converter class in json_encoder.py to pyscan/general. Th…" #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erencing np.float_ which was removed in numpy 2.0." This reverts commit 415139c.
…erencing np.float_ which was removed in numpy 2.0." This reverts commit 44c57a7.
This reverts commit 3803461.
This reverts commit 67d1234.
…r the file changes from previous commits and import successfully with a new order since itemattribute is used in other pyscan/general modules now." This reverts commit b71882d.
…json decoder item_attribute_object_hook." This reverts commit 542c68f.
…from abstract expt." This reverts commit afeba85.
…Encoder class." This reverts commit 574103e.
…es metadata now implemented in abstract experiment's save_metadata method." This reverts commit c7e17ce.
…t that was causing a type error." This reverts commit 7edb7d9.
This reverts commit 368f888.
…aving numpy data types and consolidated the json converter added in the last commit to the pre existing recursive_to_dict function which can now handle numpy data types for saving." This reverts commit 18c4baf.
… pyscan/general. This is now implemented in the save_metadata method of abstract_experiment.py which enables numpy values to be used as data inputs before saving. The converter changes the numpy values to standard python values and no longer throws the same type error as before." This reverts commit 09ebcde.
i-am-mounce
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #184