Stanford830 #226
Merged
Stanford830 #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and increasing robustness.
…ow passing the test cases. A debug setting is included to debug the test_driver() function; however, this will bypass the test log. An updated error message is included to point to setting the debug parameter to true for debugging purposes.
…uitive debugging. Now only logs tests when they pass. Note: The Stanford830 driver has a buffer_points attribute mentioned in the docstring but nowhere else and so is failing the test nb. Make sure this is fixed in the stanford830 branch.
…utes and methods have corresponding doc strings, but that all attributes and methods listed in the docstring are implemented in the drivers contents. Needs to be tested.
…e readable line breaks. Must be tested.
…s now have a verbose option (defaults to True), to offer an option to clean up outputs which have been further refined in general. Testing for implementation and presence of attributes and methods in drivers docstrings is now implemented and validated. Furthermore, since we are now only logging the most recent passing of drivers, test logging has been updated to only save one line for simplicity, legibility, and maintainability, unless otherwise specified through the save_multiple_lines parameter.
|
Please note, the readthedocs build initially failed, and then succeeded once I entered an empty commit with absolutely no changes to it. Nothing to take action with but something to be aware of. |
|
Also, the stanford830 is not passing test cases because it has buffer_points in the docstring but not in the driver itself. This should be fixed before this PR is pulled. |
… logging results.
…to stanford830
…pends on time constant
mplilly4395
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_driver() function has been updated to include a debugging option. The stanford830 has been updated to follow proper docstring syntax. The test cases are passing and this is reflected in the test log.