Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct list references to always use positive indexing. #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brantfaircloth
Copy link

Howdy,

I was using PretextView to correct some scaffolds, and I noticed upon correcting and "painting" a handful of scaffolds and exported the AGP file, the AGPCorrect.py script was failing when run against that AGP file. That failure was due to the fact that AGPCorrect.py was using negative list indexing... and when you add more columns (during correction), the negative indexes point to the wrong places.

I think the following corrects that error by switching the negative indexes to positive ones. There are some scaffolds that get "out-of-order" in the AGP, as well, but that seems to be how PretextView exports them (and all scaffolds/contigs are accounted for in the output - some are just slightly out-of-order).

@brantfaircloth
Copy link
Author

Ha! Just noticed that this recapitulates most of what is in #22, although these changes don't appear to be integrated to the main branch (i,e., the problem still exists).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant