-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dp24 vecscreen2 updates #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi eerik, Once your ok with PR #41 we can get this merged in. |
eeaunin
reviewed
Nov 20, 2023
…n test to test.yaml
eeaunin
reviewed
Nov 20, 2023
I think this look good to me, is it going to be merged into Eerik's branch? |
yumisims
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some formatting changes to match other subworkflows, Harshil alignments and module explainers.
Channel changes, I've changed the vecscreen_tuple creation so it is in the yaml_input subworkflow (parity with other inputs for other subworkflows).
Added prefix variable to two modules to match convention on not hardcoding files
Added args variable to one module, typically optional arguments for a script should be set in the modules.config file not in the module itself.