-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrected bin/chunk_assembly_for_vecscreen.py #42
Conversation
|
bin/chunk_assembly_for_vecscreen.py
Outdated
@@ -1,36 +1,45 @@ | |||
#!/usr/bin/env python3 | |||
""" | |||
Script for chunking an assembly before running NCBI VecScreen. Adapted from a script by James Torrance. | |||
The script was further refactored by Eerik Aunin and Yumi Sims | |||
Script for chunking an assembly before running NCBI VecScreen. Adapted from a script by James Torrance, edited by Eerik Aunin and Yumi Sims |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add Damon's name here as well, as he edited the script too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing this new version of the script with the PlasmoDB-66_Pfalciparum3D7_Genome.fasta
assembly (/lustre/scratch123/tol/teams/tola/users/ea10/pipeline_testing/20231120_vecscreen_chunk_test/PlasmoDB-66_Pfalciparum3D7_Genome.fasta
), there is still some small difference between the output of this script and the old script from James.
This script: 25262914 bp, 55 sequences /lustre/scratch123/tol/teams/tola/users/ea10/pipeline_testing/20231120_vecscreen_chunk_test/PlasmoDB-66_Pfalciparum3D7_Genome.chunks.yumi_v2.fasta
James's script: 25182839 bp, 53 sequences
/lustre/scratch123/tol/teams/tola/users/ea10/pipeline_testing/20231120_vecscreen_chunk_test/PlasmoDB-66_Pfalciparum3D7_Genome.chunks.james.fasta
But this small difference probably doesn't matter for VecScreen
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).