-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y24-475 - [BUG] Improve integration suite UAT actions error message. #477
Y24-475 - [BUG] Improve integration suite UAT actions error message. #477
Comments
Related to #460 |
Integration Suite PR: Y24-475 PR [Integration] bug improve integration suite uat actions error message |
Notes: If the purpose for a new pipeline is not recorded in the database, typically happened in the training environment because of the WIP records not enabled, because the existing code did not check if the given purpose existed for the The following example shows the fix for the generate plates UAT action. It sends and invalid plate purpose name and prints the response body; writes the status and response headers to response_headers.txt
Most wip related issues cause failures for WIP pipelines at the start, either while generating a plate or doing a submission. Therefore, the next change to focus on is the test submission UAT action. Validation examples:
Updated the tube submission and the generate sample manifest UAT actions as well. |
Describe the bug
When running the integration suite in training we might get an error for work in progress pipelines where the plate purpose or some other data is missing in sequencescape when performing UAT actions. Currently this returns a 404 not found for the uat_actions sequencescape link. This is a misleading error message because the uat_actions URL exists but the post action has invalid data so it should be a 400.
An example of this is here:
Failures:
Failure/Error: raise Failure, "Couldn't find action: #{url}, #{e.response.body}"
UatAction::Failure:
Couldn't find action: https://<training_sequencescape_url>/uat_actions, {"status":404,"error":"Not Found"}
In this case the bad input is the plate purpose, which is currently WIP and therefore not added to the purpose configs.
RT Ticket Number
If applicable
To Reproduce
Steps to reproduce the behaviour:
Run an integration suite test with a 'generateplates' UAT action and pass it invalid data like an incorrect plate_purpose_name.
Expected behaviour
I should get a more descriptive 400 error saying the cause of the failure.
The text was updated successfully, but these errors were encountered: