-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y24-475 [PR] [BUG] Improve integration suite UAT actions error message #4596
Y24-475 [PR] [BUG] Improve integration suite UAT actions error message #4596
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4596 +/- ##
===========================================
+ Coverage 89.28% 89.41% +0.12%
===========================================
Files 1407 1407
Lines 30244 30332 +88
===========================================
+ Hits 27003 27121 +118
+ Misses 3241 3211 -30 ☔ View full report in Codecov by Sentry. |
… other validations
…-actions-error-message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good comprehensive error messaging and test coverage, nice work.
Just wondering about combining presence validation and existing record validation into one in some places so we don't perform multiple checks.
…anifest uat action
…-actions-error-message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Closes #
Changes proposed in this pull request
See also command line examples in the story comment sanger/General-Backlog-Items#477 (comment)
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version