Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-191: Add API keys to SS requests #958

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

sdjmchattie
Copy link
Contributor

Closes #950

Changes proposed in this pull request

  • Add the SS authentication headers to all requests for SS.
  • Add tests to ensure the headers are always present.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code

Copy link
Contributor

@KatyTaylor KatyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So looks like this was mostly implemented already (adding API key to requests), but just a couple were missed?

@sdjmchattie
Copy link
Contributor Author

So looks like this was mostly implemented already (adding API key to requests), but just a couple were missed?

Yep that's right. The request header addition should probably have been somewhere more central, but this is a legacy product as far as Tom keeps telling us, so I went for the minimal viable solution.

@sdjmchattie sdjmchattie merged commit cf265af into develop Jul 19, 2024
6 checks passed
@sdjmchattie sdjmchattie deleted the Y24-191-add-api-keys-to-ss-requests branch July 19, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-191 - Use the v2 API key for all Sequencescape requests
2 participants