Update eslint

sanger · Jun 2, 2020 · 0bba0a7 · 0bba0a7
1 parent 57d4718
commit 0bba0a7
Show file tree

Hide file tree

Showing 5 changed files with 221 additions and 176 deletions.
diff --git a/app/javascript/custom-tagged-plate/components/CustomTaggedPlate.vue b/app/javascript/custom-tagged-plate/components/CustomTaggedPlate.vue
@@ -513,7 +513,7 @@ export default {
       return this.calcNumTagsForSeqPlate()
     },
     checkTagForSubstitution(tagMapId) {
-      if(this.tagSubstitutions.hasOwnProperty(tagMapId)) {
+      if(Object.prototype.hasOwnProperty.call(this.tagSubstitutions,tagMapId)) {
         tagMapId = this.tagSubstitutions[tagMapId]
       }
 

diff --git a/app/javascript/custom-tagged-plate/tagClashFunctions.js b/app/javascript/custom-tagged-plate/tagClashFunctions.js
@@ -94,7 +94,7 @@ function extractChildUsedOligos(parentUsedOligos, parentWellSubmDetails, tagLayo
       let tagMapId = tagMapIds[i]
 
       // check for tag substitution
-      if(tagSubstitutions.hasOwnProperty(tagMapId)) {
+      if (Object.prototype.hasOwnProperty.call(tagSubstitutions,tagMapId)) {
         tagMapId = tagSubstitutions[tagMapId]
       }
 

diff --git a/app/javascript/shared/devourApiValidators.js b/app/javascript/shared/devourApiValidators.js
@@ -6,7 +6,7 @@ const hasExpectedProperties = (expectedProperties) => {
         const expectedPropertiesLength = expectedProperties.length
         for (var propIndex = 0; propIndex < expectedPropertiesLength; propIndex++) {
           const expectedPropertyName = expectedProperties[propIndex]
-          if(!currTagGroup.hasOwnProperty(expectedPropertyName)) {
+          if (!Object.prototype.hasOwnProperty.call(currTagGroup, expectedPropertyName)) {
             return { valid: false, message: 'Results objects do not contain expected properties' }
           }
         }

diff --git a/package.json b/package.json
@@ -39,9 +39,9 @@
     "@vue/test-utils": "^1.0.0-beta.25",
     "axios-mock-adapter": "^1.15.0",
     "babel-eslint": "^10.0.1",
-    "eslint": "^5.15.1",
-    "eslint-plugin-jasmine": "^2.10.1",
-    "eslint-plugin-vue": "^5.2.3",
+    "eslint": "^6.0.0",
+    "eslint-plugin-jasmine": "^4.1.1",
+    "eslint-plugin-vue": "^6.2.2",
     "jasmine-core": "^3.2.1",
     "karma": "^5.0.9",
     "karma-chrome-launcher": "^3.1.0",