fix: allow pools to not be defined without breaking all javascript

sanger · Oct 17, 2024 · d8b7b29 · d8b7b29
1 parent f1b6287
commit d8b7b29
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/app/frontend/javascript/legacy_scripts_a.js b/app/frontend/javascript/legacy_scripts_a.js
@@ -59,9 +59,12 @@ let limberPlateView = function (defaultTab) {
   control.find('a[href="' + defaultTab + '"]').tab('show')
 
   plateElement.on('click', '.aliquot', function (event) {
+    control.find('a[data-plate-view="pools-view"]').tab('show')
+
     let pool = $(event.currentTarget).data('pool')
 
-    control.find('a[data-plate-view="pools-view"]').tab('show')
+    // Handle cases where pool is not defined to prevent errors
+    if (pool === undefined || pool === '') return
 
     plateElement
       .find('.aliquot[data-pool!=' + pool + ']')