Merge pull request #1555 from sanger/dpl-1047-upgrade-to-node-20

DPL-1047: Upgrade to Node 20
sanger · Aug 19, 2024 · e6dbcf0 · e6dbcf0
2 parents 93ff0e0 + 4bc2dd3
commit e6dbcf0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v18.20.4
+v20.16.0
diff --git a/Dockerfile b/Dockerfile
@@ -12,11 +12,8 @@ RUN apt-get install -y build-essential
 RUN apt-get install -y curl
 RUN apt-get install -y git
 
-# TODO:
-# Set Node to install version 16+, a more recent version such as 20 is recommended
-#   https://github.com/nodesource/distributions
 RUN set -uex \
-    && NODE_MAJOR=18 \
+    && NODE_MAJOR=20 \
     && apt-get update \
     && apt-get install -y ca-certificates curl gnupg \
     && mkdir -p /etc/apt/keyrings \