DPL-1059: Group graph pipelines #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
StephenHulme
added
Size: S
| end | ||
|
|
||
| def calculate_pipeline_edges | ||
| calculate_edges_with_pipeline_data.map do |edge| |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| end | ||
| end | ||
|
|
||
| def calculate_group_edges | ||
| calculate_edges_with_pipeline_data |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
KatyTaylor
reviewed
Jan 24, 2024
|
Thanks for the feedback @KatyTaylor, much appreciated! |
| * @returns {cytoscape.Collection} - A collection of nodes and edges that match the query. | ||
| */ | ||
| const findResults = (cy, query) => { | ||
| const findResults = (cy, filter) => { |
There was a problem hiding this comment.
Function findResults has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit 7432b32 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 36.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.1% (-0.1% change). View more on Code Climate. |
KatyTaylor
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1558
Changes proposed in this pull request
pipelines.jsonto include pipeline groupsBefore:
After:
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version