DPL-1047-18: Upgrade Node to v18 (as a stepping stone) #1645

StephenHulme · 2024-03-22T10:52:53Z

Moves closer to closing #1541, as upgrading to v20 is non-trivial (see #1555)

This PR is built on top of the Node 16 upgrade PR

Changes proposed in this pull request

Upgrade Node 16 -> 18

Deployment Instructions

Needs to be thoroughly tested in UAT before merging and deploying

Developer Hints

Run this command from the repository's root directory to remove old coverage and build files:

rm -r app/javascript/coverage/ public/packs*/ public/assets/

These are auto-generated, so nothing should be lost.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
- Check story numbers included
- Check for debug code
- Check version

codecov · 2024-03-22T11:04:19Z

Codecov Report

Attention: Patch coverage is 92.68293% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.48%. Comparing base (baf1b58) to head (5df096e).
Report is 13 commits behind head on dpl-1047-16-upgrade.

Files	Patch %	Lines
lib/purpose_config.rb	0.00%	4 Missing ⚠️
app/frontend/javascript/test_support/factories.js	33.33%	2 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                   @@
##           dpl-1047-16-upgrade    #1645      +/-   ##
=======================================================
+ Coverage                91.40%   91.48%   +0.07%     
=======================================================
  Files                      376      378       +2     
  Lines                     7656     7713      +57     
=======================================================
+ Hits                      6998     7056      +58     
+ Misses                     658      657       -1

Flag	Coverage Δ
javascript	`93.67% <81.81%> (+0.02%)`	⬆️
pull_request	`91.48% <92.68%> (?)`
push	`91.48% <92.68%> (+0.07%)`	⬆️
ruby	`91.17% <94.36%> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

StephenHulme · 2024-07-12T15:20:45Z

app/javascript/asset-comments/components/AssetComments.spec.js

app/javascript/custom-tagged-plate/index.js

$ bin/vite dev Your `bin/bundle` was not generated by Bundler, so this binstub cannot run. Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.

StephenHulme · 2024-07-29T14:37:27Z

app/frontend/stylesheets/limber/_labware-mixins.scss

@@ -76,14 +80,16 @@
    .aliquot:hover {
      color: #ffd600;
      cursor: pointer;
-      @extend .selected-aliquot;
+      // @extend .selected-aliquot; // TODO: Remove circular reference


This should be checked in UAT, likely related to failing wells

app/views/application/_header.html.erb

StephenHulme · 2024-07-29T14:56:23Z

app/views/plate_creation/tagged_plate.html.erb

-     })(window,jQuery);
-  </script>
+  <div id="labware-creator-config"
+      data-tag-plates-list="<%= @labware_creator.tag_plates_list.to_json %>"


Check if quoted quotes work with .to_json

Co-authored-by: Stuart McHattie <[email protected]>

…babel7-7.25.2" This reverts commit 4a2b695, reversing changes made to d4e0743.

I suspect this is not actually used in production... See deployment:/roles/deploy_limber/templates/environment_template.rb.j2

codeclimate

The PR diff size of 9776 lines exceeds the maximum allowed for the inline comments feature.

codeclimate · 2024-08-05T11:15:33Z

Code Climate has analyzed commit 2257718 and detected 92 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	35
Duplication	57

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

StephenHulme force-pushed the dpl-1047-18-upgrade branch from 9439fb5 to 3db2bab Compare March 22, 2024 10:56

StephenHulme force-pushed the dpl-1047-18-upgrade branch from 78e0093 to 21f453b Compare July 12, 2024 10:33

build: upgrade to node v18

3a006c9

build: update broweser versions

4b37898

yoldas reviewed Jul 12, 2024

View reviewed changes

app/javascript/asset-comments/components/AssetComments.spec.js Outdated Show resolved Hide resolved

app/javascript/custom-tagged-plate/index.js Outdated Show resolved Hide resolved

StephenHulme added 15 commits July 12, 2024 17:08

build: upgrade webpack-cli

54442d6

build: add missing css-loader peer dependency

3b6a19a

build: upgrade webpacker to v5

3bea9f2

build: remove unused conflicting plugin

3fcac4e

build: replace webpacker with vite

6eb5a11

build: install vite

f46d4b0

build: partial removal of webpacker

42fed55

build: update bundle

3f43ceb

$ bin/vite dev Your `bin/bundle` was not generated by Bundler, so this binstub cannot run. Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.

build: partial update of vite config

d32d2a3

build: add missing dependencies

65cc278

build: remove more webpack-related files

22bb8d3

build: fix more broken dependencies

fe843b2

build: move packs to entrypoints

9107274

build: update imports and references for vite

0f03204

build: specify undefined dependency

bb97653

StephenHulme self-assigned this Jul 16, 2024

StephenHulme added 7 commits July 16, 2024 13:29

build: install vue plugin for vite

591c2c2

fix: specify vue files in imports

90ca3a6

build: add sass dependency

b33af8c

build: update docker install to node v18

f9fbf0a

fix: simplify asset tags to always use vite instead of rails assets

f617ea7

style: lint

fc92601

fix: apply stricter linting to sass files

e63b1e4

StephenHulme commented Jul 29, 2024

View reviewed changes

app/views/application/_header.html.erb Show resolved Hide resolved

StephenHulme commented Jul 29, 2024

View reviewed changes

andrewsparkes approved these changes Jul 29, 2024

View reviewed changes

yoldas approved these changes Jul 29, 2024

View reviewed changes

StephenHulme and others added 2 commits July 29, 2024 16:18

style: fix comment typo

eef3c21

Co-authored-by: Stuart McHattie <[email protected]>

style: replace grandfathered with legacy

b69a5cd

sdjmchattie approved these changes Jul 29, 2024

View reviewed changes

StephenHulme added 9 commits July 29, 2024 16:39

build: remove assets and sprockets

b8a767b

Merge branch 'develop' into dpl-1047-18-upgrade

9283dce

style: lint

572c56e

fix: remove another assets config

123f7a9

build: remove now-unused directories from gitignore

bb2cfdf

build: update docker ignore

c84aec2

docs: add MissingEntrypointError debugging suggestions

d78d8ef

build: remove more unused asset references and packages

f55d78c

build: update gemfile.lock

1ab870b

KatyTaylor mentioned this pull request Jul 31, 2024

Y24-226 - Test Sequencescape and Limber setup sanger/sequencescape#4246

Open

StephenHulme added 4 commits August 2, 2024 15:12

Revert "Merge pull request #1819 from sanger/depfu/update/yarn/group/…

f2209fe

…babel7-7.25.2" This reverts commit 4a2b695, reversing changes made to d4e0743.

Merge branch 'develop-sans-depfu-js-updates' into dpl-1047-18-upgrade

e135335

build: set RAILS_ENV to production in compilation script

d6cda1f

fix: add missing sprint_uri to production config

5df096e

I suspect this is not actually used in production... See deployment:/roles/deploy_limber/templates/environment_template.rb.j2

Base automatically changed from dpl-1047-16-upgrade to develop August 5, 2024 11:02

Merge branch 'develop' into dpl-1047-18-upgrade

2257718

codeclimate bot reviewed Aug 5, 2024

View reviewed changes

StephenHulme merged commit 1b14bff into develop Aug 5, 2024
10 checks passed

StephenHulme deleted the dpl-1047-18-upgrade branch August 5, 2024 11:16

StephenHulme mentioned this pull request Aug 5, 2024

Release for 6 August #1831

Merged

StephenHulme mentioned this pull request Oct 24, 2024

build: install turbo #2022

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DPL-1047-18: Upgrade Node to v18 (as a stepping stone) #1645

DPL-1047-18: Upgrade Node to v18 (as a stepping stone) #1645

StephenHulme commented Mar 22, 2024 •

edited

Loading

codecov bot commented Mar 22, 2024 •

edited

Loading

StephenHulme commented Jul 12, 2024 •

edited

Loading

StephenHulme Jul 29, 2024

StephenHulme Jul 29, 2024

codeclimate bot left a comment

codeclimate bot commented Aug 5, 2024

DPL-1047-18: Upgrade Node to v18 (as a stepping stone) #1645

DPL-1047-18: Upgrade Node to v18 (as a stepping stone) #1645

Conversation

StephenHulme commented Mar 22, 2024 • edited Loading

Changes proposed in this pull request

Deployment Instructions

Developer Hints

Instructions for Reviewers

codecov bot commented Mar 22, 2024 • edited Loading

Codecov Report

StephenHulme commented Jul 12, 2024 • edited Loading

StephenHulme Jul 29, 2024

Choose a reason for hiding this comment

StephenHulme Jul 29, 2024

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot commented Aug 5, 2024

StephenHulme commented Mar 22, 2024 •

edited

Loading

codecov bot commented Mar 22, 2024 •

edited

Loading

StephenHulme commented Jul 12, 2024 •

edited

Loading