-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent codecov from publishing coverage report early #1806
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1806 +/- ##
========================================
Coverage 91.40% 91.40%
========================================
Files 376 376
Lines 7656 7656
========================================
Hits 6998 6998
Misses 658 658
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Also add warnings to test workflows
codecov: | ||
notify: | ||
# do not notify until at least n builds have been uploaded from the CI pipeline | ||
after_n_builds: 4 # js_test (push), js_test (pull_request), ruby_test (push), ruby_test (pull_request) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👨🏻🍳 😚 👌🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible. What happens if an action is cancelled or a test suite fails, does that still count as a 'build'?
I think 'build' in this context is any uploaded coverage report. In this case, I imagine that no report will be generated - which is probably sensible since it doesn't have sufficient data. A more active failure mode might be preferable, but I think this is a reasonable tradeoff for the increased accuracy. |
Code Climate has analyzed commit 475d6da and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.0% (0.0% change). View more on Code Climate. |
JS tests finish before Ruby tests, meaning CodeCov publishes it's report before all information has been recieved.
Changes proposed in this pull request
Related to
DPL-1034: Combine code coverage from both Javascript and Ruby code
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version