-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPL-1047: Cleanup - upgrade code linting to ES9 standard #1869
Conversation
yarn lint --fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1869 +/- ##
===========================================
+ Coverage 74.54% 74.95% +0.41%
===========================================
Files 421 420 -1
Lines 14379 14300 -79
===========================================
Hits 10719 10719
+ Misses 3660 3581 -79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super familiar with the changes taking place here, but they look fine. Git isn't doing a very nice job of aligning the removed/added lines in the diff where very little has changed. Main things I observed were the change of jquery imports to use $
as the imported name and changing some var
usage to let
. Indent changes I wasn't sure why they happened, but it looks fine and obviously it works.
The individual scripts were previously wrapped in local functions. Removing these anonymous wrappers is the cause of the spacing changes. Since ES6, modules are scoped by default and the wrappers are no longer necessary. |
Code Climate has analyzed commit 8c455ec and detected 11 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.1% (0.0% change). View more on Code Climate. |
Closes #1555
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version