Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-207: fix incorrect test coverage for Vue SFC components #1900

Conversation

seenanair
Copy link
Contributor

@seenanair seenanair commented Sep 6, 2024

Closes #1801

Changes proposed in this pull request

  • Removed 'ignore' vue files section in codecov.yml

With the addition of "coverageProvider": "v8" to vite.config.mjs, the Vue SFC code coverage is now working as expected.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@seenanair seenanair changed the title chore: Remove ignore .vue files section in codecov.yml y24-207: fix incorrect test coverage for Vue SFC components Sep 6, 2024
@seenanair seenanair changed the title y24-207: fix incorrect test coverage for Vue SFC components Y24-207: fix incorrect test coverage for Vue SFC components Sep 6, 2024
Copy link

codeclimate bot commented Sep 6, 2024

Code Climate has analyzed commit 76320b4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.45%. Comparing base (e2db5f4) to head (76320b4).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1900      +/-   ##
===========================================
+ Coverage    74.93%   77.45%   +2.52%     
===========================================
  Files          420      455      +35     
  Lines        14316    17273    +2957     
  Branches         0      228     +228     
===========================================
+ Hits         10727    13379    +2652     
- Misses        3589     3892     +303     
- Partials         0        2       +2     
Flag Coverage Δ
javascript 68.60% <ø> (+8.27%) ⬆️
pull_request 77.45% <ø> (?)
push 77.45% <ø> (+2.52%) ⬆️
ruby 91.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this - much better 👌
Will be really great having proper coverage for the Vue components now.

@seenanair seenanair merged commit efbb816 into develop Sep 6, 2024
14 checks passed
@seenanair seenanair deleted the y24-207-fix-incorrect-test-coverage-from-vue-single-file-components branch September 6, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-207 - [BUG] Incorrect test coverage from Vue Single-File Components
2 participants