Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop to master #1912

Merged
merged 25 commits into from
Sep 17, 2024
Merged

Develop to master #1912

merged 25 commits into from
Sep 17, 2024

Conversation

dasunpubudumal
Copy link
Contributor

@dasunpubudumal dasunpubudumal commented Sep 12, 2024

Closes #1485 #1486

Changes proposed in this pull request

  • Support sequencing-only uploads for tube rack transfers

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

dasunpubudumal and others added 21 commits September 3, 2024 11:56
…ack-support-sequencing-only' into uat-staging-deployments-11-09-2024
FIX - added SGE library type to bespoke pcr pipeline
…ack-support-sequencing-only

Updating tube rack form submission for PBMC plates to make contingency upload optional
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.46%. Comparing base (2c44c7e) to head (134bb71).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
...dels/labware_creators/plate_split_to_tube_racks.rb 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1912      +/-   ##
==========================================
- Coverage   77.46%   77.46%   -0.01%     
==========================================
  Files         455      455              
  Lines       17272    17275       +3     
  Branches      229      229              
==========================================
+ Hits        13380    13382       +2     
- Misses       3890     3891       +1     
  Partials        2        2              
Flag Coverage Δ
javascript 68.61% <ø> (ø)
pull_request 77.46% <95.00%> (-0.01%) ⬇️
push 77.46% <95.00%> (-0.01%) ⬇️
ruby 91.13% <95.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…dencies-bug

build: repair optional dependencies bug
@dasunpubudumal dasunpubudumal merged commit cd32061 into master Sep 17, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants