Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly label Submission state #1989

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

StephenHulme
Copy link
Contributor

The Submission State was incorrectly labelled as a Labware State

Changes proposed in this pull request

  • Fix the label to read Submission State, while keeping Labware State for other usages
Screenshot 2024-10-14 at 12 01 05 Screenshot 2024-10-14 at 12 01 19

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.10%. Comparing base (0c7e26e) to head (5642ec3).
Report is 53 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1989      +/-   ##
===========================================
+ Coverage    77.97%   78.10%   +0.13%     
===========================================
  Files          459      463       +4     
  Lines        17699    17933     +234     
  Branches       225      225              
===========================================
+ Hits         13800    14007     +207     
- Misses        3897     3924      +27     
  Partials         2        2              
Flag Coverage Δ
javascript 69.68% <ø> (-0.02%) ⬇️
pull_request 77.96% <100.00%> (-0.01%) ⬇️
push 77.97% <100.00%> (ø)
ruby 91.08% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codeclimate bot commented Oct 21, 2024

Code Climate has analyzed commit 5642ec3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

@StephenHulme StephenHulme self-assigned this Oct 21, 2024
@StephenHulme StephenHulme added the Bug Bug in code label Oct 21, 2024
@StephenHulme StephenHulme merged commit 40ef006 into develop Oct 21, 2024
15 checks passed
@StephenHulme StephenHulme deleted the sh51/repair-incorrect-tooltip branch October 21, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug in code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants