Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-051: Hide pools tab on stock plates #2119

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

StephenHulme
Copy link
Contributor

Closes #1667

See also #2080

Changes proposed in this pull request

  • Hide pools tab for all stock plates

Screenshot

Screenshot 2024-12-10 at 13 02 12

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme
Copy link
Contributor Author

Not sure who to tag for review (#1667 currently isn't very clear on acceptance criteria) - please ignore if not relevent

@StephenHulme StephenHulme changed the title fix: hide pools tab on stock plates Y24-051: Hide pools tab on stock plates Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.43%. Comparing base (7bcab7c) to head (ae70877).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2119   +/-   ##
========================================
  Coverage    80.43%   80.43%           
========================================
  Files          471      471           
  Lines        17932    17933    +1     
  Branches       268      268           
========================================
+ Hits         14424    14425    +1     
  Misses        3506     3506           
  Partials         2        2           
Flag Coverage Δ
javascript 73.60% <ø> (ø)
pull_request 80.43% <100.00%> (-0.01%) ⬇️
push 80.43% <100.00%> (+<0.01%) ⬆️
ruby 91.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-051 [BUG] Limber can display an incorrect nonexistent pool and incorrect warnings for some stock plates.
1 participant