DPL-865 handle sprint client response #2130
Conversation
[release] Merge Develop into Master
[release] Merge Develop into Master
[release] Merge Develop into Master
…-handle-sprint-client-response
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2130 +/- ##
===========================================
+ Coverage 80.78% 80.80% +0.02%
===========================================
Files 476 476
Lines 18185 18206 +21
Branches 269 269
===========================================
+ Hits 14691 14712 +21
Misses 3492 3492
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…r-handle-sprint-client-response
| expect(SPrintClient).to receive(:send_print_request).with( | ||
| printer_sprint.name, | ||
| label_template_name_sprint, | ||
| labels_sprint.values | ||
| ) | ||
| expect(pj.print_to_sprint).to eq(true) | ||
| end | ||
|
|
||
| it 'will not execute if the SPrintClient is down' do | ||
| response = Net::HTTPBadGateway.new(1.0, '502', nil) |
There was a problem hiding this comment.
Could we also test the errors for Net::HTTPUnprocessableEntity and Net::HTTPInternalServerError as they have separate routes / error messages.
There was a problem hiding this comment.
I just added two more tests, but Codecov is still complaining?
There was a problem hiding this comment.
Nice, they look good. Think codecov is complaining about coverage in extract_error_message method
There was a problem hiding this comment.
Fixed it. Thanks.
Closes #1352
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version