Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-102 tube rack banking bed verification #2156

Open
wants to merge 20 commits into
base: y24-088-tuberacks-epic
Choose a base branch
from

Conversation

andrewsparkes
Copy link
Member

Closes #1699

@andrewsparkes andrewsparkes self-assigned this Jan 13, 2025
@andrewsparkes andrewsparkes requested a review from yoldas January 13, 2025 16:28
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.87%. Comparing base (b158151) to head (a689f37).
Report is 40 commits behind head on y24-088-tuberacks-epic.

Files with missing lines Patch % Lines
...pp/sequencescape/sequencescape/api/v2/tube_rack.rb 83.33% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           y24-088-tuberacks-epic    #2156      +/-   ##
==========================================================
+ Coverage                   80.81%   80.87%   +0.05%     
==========================================================
  Files                         482      482              
  Lines                       18349    18393      +44     
  Branches                      269      269              
==========================================================
+ Hits                        14829    14875      +46     
+ Misses                       3518     3516       -2     
  Partials                        2        2              
Flag Coverage Δ
javascript 74.23% <ø> (ø)
pull_request 80.82% <95.65%> (+<0.01%) ⬆️
push 80.81% <95.83%> (+<0.01%) ⬆️
ruby 91.19% <96.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsparkes andrewsparkes linked an issue Jan 16, 2025 that may be closed by this pull request
2 tasks
Copy link
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a discussion point I think.

@yoldas
Copy link
Member

yoldas commented Jan 29, 2025

There are some comments need updating (I have searched the text 'wrapper' in ./app/models/robots):

  • top-level comments of app/models/robots/plate_to_tube_racks_robot.rb
  • description of the find_bed_labware method
  • description of the add_tube_racks_to_labware_store method
  • description of the labware_store method
  • return value description of the child_labware method

Copy link
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real bed verification with tube racks! Well documented and tested. Looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-102 Tube Rack Banking Bed verification
2 participants