Skip to content

Commit

Permalink
Merge pull request #268 from sanger/develop
Browse files Browse the repository at this point in the history
Node upgrade
  • Loading branch information
Sangeetha-Bheeman authored Oct 23, 2023
2 parents 85c25cc + 51bea08 commit 8d35758
Show file tree
Hide file tree
Showing 5 changed files with 3,720 additions and 2,800 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/manual_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ jobs:
name: Build Release
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Setup node
uses: actions/setup-node@v2
with:
node-version: '14'
node-version-file: '.nvmrc'
- name: Install
run: yarn install
- name: Compile build
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.13.1
v18.18.0
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,17 @@ Does what it says on the tin.
yarn install
```

Added @achrinza/node-ipc@10.1.9(which already exists as part of the package dependency tree) to package.json
resolutions to fix the version incompatibility issue with node.

### Compiles and hot-reloads for development

```shell
yarn run serve
```

Added --openssl-legacy-provide to NODE_OPTIONS on serve and build scripts in package.json to resolve the error:0308010C:digital envelope routines::unsupported discussed here https://github.com/vuejs/vue-cli/issues/6770. This can be removed later when the issue is resolved.

### Compiles and minifies for production

```shell
Expand Down
7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"version": "2.1.0",
"private": true,
"scripts": {
"serve": "vue-cli-service serve",
"build": "vue-cli-service build",
"serve": "export NODE_OPTIONS=--openssl-legacy-provider && vue-cli-service serve",
"build": "export NODE_OPTIONS=--openssl-legacy-provider && vue-cli-service build",
"test:unit": "vue-cli-service test:unit",
"test:e2e": "vue-cli-service test:e2e",
"lint": "vue-cli-service lint",
Expand All @@ -24,6 +24,9 @@
"vue-router": "^3.5.4",
"vue-simple-spinner": "^1.2.10"
},
"resolutions": {
"@achrinza/node-ipc": "10.1.9"
},
"devDependencies": {
"@vue/cli-plugin-babel": "~4.5.19",
"@vue/cli-plugin-e2e-cypress": "~4.5.19",
Expand Down
Loading

0 comments on commit 8d35758

Please sign in to comment.