-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y24-190-3: Support Limber with an API v2 endpoint for PooledPlateCreations #4355
Y24-190-3: Support Limber with an API v2 endpoint for PooledPlateCreations #4355
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-Y24-190 #4355 +/- ##
===================================================
- Coverage 87.66% 87.63% -0.04%
===================================================
Files 1389 1391 +2
Lines 29988 30011 +23
===================================================
+ Hits 26290 26301 +11
- Misses 3698 3710 +12 ☔ View full report in Codecov by Sentry. |
app/models/plate_creation.rb
Outdated
@@ -7,6 +7,7 @@ class PlateCreation < AssetCreation | |||
# This is the child that is created from the parent. It cannot be assigned before validation. | |||
belongs_to :parent, class_name: 'Plate' | |||
attr_accessor :barcode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can barcode be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think it could as it seemed like it was tied into the same named attribute on another class, but I've just done so and all tests still pass. I did have to update a factory.
Closes #4244
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code