Y24-190-3: Support Limber with an API v2 endpoint for PooledPlateCreations #4355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-Y24-190 #4355 +/- ##
===================================================
- Coverage 87.66% 87.63% -0.04%
===================================================
Files 1389 1391 +2
Lines 29988 30011 +23
===================================================
+ Hits 26290 26301 +11
- Misses 3698 3710 +12 ☔ View full report in Codecov by Sentry. |
BenTopping
reviewed
Sep 20, 2024
app/models/plate_creation.rb
Outdated
| @@ -7,6 +7,7 @@ class PlateCreation < AssetCreation | |||
| # This is the child that is created from the parent. It cannot be assigned before validation. | |||
| belongs_to :parent, class_name: 'Plate' | |||
| attr_accessor :barcode | |||
There was a problem hiding this comment.
Can barcode be removed?
There was a problem hiding this comment.
I didn't think it could as it seemed like it was tied into the same named attribute on another class, but I've just done so and all tests still pass. I did have to update a factory.
sdjmchattie
deleted the
Y24-190-3-support-limber-with-pooled-plate-creations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4244
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code