Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-319 - scRNA QC File #4357

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Y24-319 - scRNA QC File #4357

merged 5 commits into from
Sep 25, 2024

Conversation

BenTopping
Copy link
Contributor

Changes proposed in this pull request

  • Adds total_cell_count to list of QcResults created from the Cardinal PBMC count parser. This is required for scRNA calculations that also use this parser.

Instructions for Reviewers

Required branch for sanger/limber#1936

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (97e4f35) to head (e9a2293).
Report is 44 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4357      +/-   ##
===========================================
+ Coverage    87.53%   87.62%   +0.09%     
===========================================
  Files         1383     1383              
  Lines        29881    29882       +1     
===========================================
+ Hits         26155    26183      +28     
+ Misses        3726     3699      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenTopping BenTopping marked this pull request as ready for review September 23, 2024 14:31
Copy link
Member

@andrewsparkes andrewsparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for changing the Cardinal references throughout, more than I thought.

@andrewsparkes andrewsparkes merged commit c767ccf into develop Sep 25, 2024
23 checks passed
@andrewsparkes andrewsparkes deleted the Y24-319-scrna-qc-file branch September 25, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-319 - Pooling driver file tweaks
2 participants