y24-336 - BGE Request Types and Submissions #4511
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Plate purposes for BGE | ||
| --- | ||
| BGE Cherrypick: | ||
| type: PlatePurpose::Input | ||
| target_type: Plate | ||
| default_state: passed | ||
| stock_plate: false | ||
| cherrypickable_target: true | ||
| size: 96 | ||
| BGE Lib XP2: | ||
| target_type: Plate | ||
| default_state: passed | ||
| stock_plate: false | ||
| cherrypickable_target: true | ||
|
There was a problem hiding this comment. and only the cherrypick plate should have the cherrypickable_target true unless something special is happening here |
||
| size: 96 | ||
| BGE Lib PCR XP: | ||
| target_type: Plate | ||
| default_state: passed | ||
| cherrypickable_target: true | ||
| stock_plate: false | ||
| size: 96 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| --- | ||
| BGE: | ||
| selection_behaviour: SingleProduct |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| --- | ||
| # Y24-366 | ||
| limber_bge_pcr_free: | ||
| asset_type: Well | ||
| order: 1 | ||
| request_class_name: IlluminaHtp::Requests::StdLibraryRequest | ||
| billable: true | ||
| product_line_name: Illumina-HTP | ||
| name: Limber BGE PCR Free | ||
| acceptable_purposes: | ||
| - BGE Cherrypick | ||
| library_types: | ||
| - BGE | ||
| # For moving PCR Free plates to ISC plates | ||
| # e.g., BGE Lib XP2 -> BGE LIB PCR | ||
| limber_bge_transition: | ||
| asset_type: Well | ||
| order: 1 | ||
| billable: true | ||
| product_line_name: Illumina-HTP | ||
| name: Limber BGE Transition | ||
| request_class_name: IlluminaHtp::Requests::StdLibraryRequest | ||
| acceptable_purposes: | ||
| - BGE Lib XP2 | ||
| library_types: | ||
| - BGE | ||
| limber_bge_isc: | ||
| asset_type: Well | ||
| order: 1 | ||
| billable: true | ||
| product_line_name: Illumina-HTP | ||
| name: Limber BGE ISC | ||
| request_class_name: Pulldown::Requests::IscLibraryRequest | ||
| acceptable_purposes: | ||
| - BGE Lib PCR XP | ||
| library_types: | ||
| - BGE | ||
|
There was a problem hiding this comment. Is library type 'BGE' for all 3 of these despite them being different library preps? Seems wrong if they want to analyse the sequencing results differently. Maybe check with users. There was a problem hiding this comment. BGE Library type is already used across the pipelines (and submissions) that area already in place (that these are modelled off). It is essentially all part of one bigger pipeline where all the samples are recombined and sequenced together. |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Y24-366 | ||
| Limber-Htp - BGE PCR Free: | ||
| name: "Limber-Htp - BGE PCR Free" | ||
| submission_class_name: "LinearSubmission" | ||
| related_records: | ||
| product_line_name: Illumina-HTP | ||
| product_catalogue_name: BGE | ||
| request_type_keys: ["limber_bge_pcr_free", "limber_multiplexing"] | ||
| Limber-Htp - BGE ISC: | ||
| name: "Limber-Htp - BGE ISC" | ||
| submission_class_name: "LinearSubmission" | ||
| related_records: | ||
| product_line_name: Illumina-HTP | ||
| product_catalogue_name: BGE | ||
| request_type_keys: ["limber_bge_isc", "limber_multiplexing", "illumina_htp_novaseqx_paired_end_sequencing"] # Other request types? | ||
| Limber-Htp - BGE Transition - Automated: | ||
| name: "Limber-Htp - BGE Transition - Automated" | ||
| submission_class_name: "AutomatedOrder" | ||
| related_records: | ||
| product_line_name: Illumina-HTP | ||
| product_catalogue_name: BGE | ||
| request_type_keys: ["limber_bge_transition"] # Other request types? |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think default state is passed on these XP plates. maybe for the cherrypick as its an input plate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although I now see there are submissions for each of these plates so not sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used here -
sequencescape/app/models/transfer/state.rb
Line 30 in 2f7cdbe
So when trying to determine a plate's state, it looks first at the state of the transfer requests. If it can't determine the state from the transfer requests (there are 0 or >1 that aren't in the expected list), then it'll use the default state.
So I suppose for plates that are the first in a pipeline, they won't have transfer requests coming into them, so it'll use the default state. That's the cherrypick plate but not the other two.
Got a meeting so can't continue looking into it now, but guess it's also relevant to think about how the submission affects the state (can't remember where that code is).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @KatyTaylor is correct. I checked the other purpose configs in SS, and only the BGE Cherrypick should have the
passeddefault state.