Update rubocop-rails 2.18.0 → 2.22.2 (minor) #357

depfu · 2023-11-20T19:10:23Z

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.18.0 → 2.22.2) · Repo · Changelog

Release Notes

2.22.2

Bug fixes

#1172: Fix an error for Rails/UnknownEnv when using Rails 7.1. (@koic)

#1173: Fix an error for Rails/RedundantActiveRecordAllMethod cop when used with RuboCop 1.51 or lower. (@koic)

Changes

#1171: Change Rails/RedundantActiveRecordAllMethod to ignore delete_all and destroy_all when receiver is an association. (@masato-bkn)

#1178: Require RuboCop AST 1.30.0+. (@koic)

2.22.1

Bug fixes

#1168: Fix a false positive for Rails/DuplicateAssociation when using duplicate belongs_to associations of same class without other arguments. (@koic)

2.22.0

New features

#906: Add Rails/EnvLocal cop. (@sambostock)

#1128: Make Rails/DuplicateAssociation aware of duplicate class_name. (@koic)

#1157: Support some Rails 7.1's new querying methods for Rails/RedundantActiveRecordAllMethod. (@koic)

#1147: Support the Trilogy adapter for MySQL. (@koic)

Bug fixes

#952: Fix a false positive for Rails/NotNullColumn when using null: false for MySQL's TEXT type. (@koic)

#1041: Fix a false positive for Rails/Output when output method is called with block argument. (@koic)

#1143: Fix an error for Rails/RedundantActiveRecordAllMethod when using RuboCop 1.51 or lower. (@koic)

#1105: Fix false positives for Rails/RedundantPresenceValidationOnBelongsTo when using validates with :if or :unless options. (@koic)

#1158: Rails/HasManyOrHasOneDependent does not add offence when has_many or has_one is called on an explicit receiver. (@samrjenkins)

#1160: Fix Rails/SaveBang to ignore parenthesis. (@fatkodima)

Changes

#1152: Add more dangerous column names to Rails/DangerousColumnNames. (@r7kamura)

#1039: Deprecate Rails/ActionFilter cop; it will be disabled by default. (@koic)

#893: Support local as an environment for Rails/UnknownEnv from Rails 7.1 onward. (@ghiculescu)

2.21.2

Bug fixes

#1126: Fix a false positive for Rails/RedundantActiveRecordAllMethod when using some Enumerable's methods with block argument. (@koic)

#1121: Fix an error for Rails/SelectMap when using select(:column_name).map(&:column_name) without receiver model. (@koic)

#1119: Fix an incorrect autocorrect for Rails/RedundantActiveRecordAllMethod when all has parentheses. (@masato-bkn)

#1130: Fix crash for Rails/UniqueValidationWithoutIndex with bare validate. (@jamiemccarthy)

#1124: Fix false positives for Rails/RedundantActiveRecordAllMethod when receiver is not an Active Record model. (@koic)

2.21.1

Bug fixes

#1108: Fix an incorrect autocorrect for Rails/TimeZone when using String#to_time. (@koic)

#1109: Fix error for Rails/RedundantActiveRecordAllMethod when all is an argument for AR methods. (@masato-bkn)

#1110: Fix false positive for Rails/RedundantActiveRecordAllMethod when all has any parameters. (@masato-bkn)

2.21.0

New features

#1075: Add new Rails/SelectMap cop that checks for uses of select(:column_name) with map(&:column_name). (@koic)

#158: Add Rails/DangerousColumnNames cop. (@r7kamura)

#1072: Add TransactionMethods config for Rails/TransactionExitStatement to detect custom transaction methods. (@marocchino)

#967: Add new Rails/UnusedRenderContent cop. (@samrjenkins)

#1052: Add explicit style to Rails/I18nLazyLookup. (@sunny)

#1016: Add new Rails/RedundantActiveRecordAllMethod cop. (@masato-bkn)

Bug fixes

#1078: Fix a false negative for Rails/LexicallyScopedActionFilter when no methods are defined. (@vlad-pisanov)

#1060: Fix a false positive for Rails/HttpStatus when using symbolic value that have no numeric value mapping. (@koic)

#1004: Fix a false-positive for Rails/RootPathnameMethods on Ruby 2.4 or lower. (@r7kamura)

#1066: Fix an error for Rails/FilePath when string interpolated Rails.root is followed by a message starting with .. (@koic)

#1049: Fix an incorrect autocorrect for Rails/FilePath when File.join with Rails.root and path starting with /. (@ydah)

#1045: Fix an incorrect autocorrect for Rails/NegateInclude when using Style/InverseMethods's autocorrection together. (@koic)

#1062: Fix autocorrection for Rails/RakeEnvironment when rake task accepts arguments. (@fastjames)

#1036: Fix an error for UniqueValidationWithoutIndex when db/schema.rb is empty. (@fatkodima)

#1042: Fix no offences for Rails/SchemaComment when create_table with multi t columns. (@nipe0324)

Changes

#1056: Fix database adapter detection for nested config. (@mjankowski)

#1031: Make Lint/SafeNavigationChain allow presence_in. (@koic)

#1080: Make Rails/HttpStatus aware of string number status. (@r7kamura)

#1094: Make Rails/TimeZone aware of String#to_time. (@koic)

#1015: Make Style/InvertibleUnlessCondition aware of Active Support methods. (@koic)

#903: Read database config for Rails/BulkChangeTable from environment variable. (@joergschiller)

#1058: Relax Include path for Rails/FindBy and Rails/FindEach. (@koic)

#994: Restrict DuplicateAssociation cop to ActiveRecord. (@mjankowski)

2.20.2

Bug fixes

#1028: Fix an error for Rails/UniqueValidationWithoutIndex when the presence: true option is used alone for the validates method. (@koic)

2.20.1

Bug fixes

#1021: Fix an error for Rails/UniqueValidationWithoutIndex. (@ydah)

2.20.0

New features

#999: Add autocorrection for Rails/Date. (@r7kamura)

#991: Add autocorrection for Rails/FilePath. (@r7kamura)

#988: Add autocorrection for Rails/IgnoredSkipActionFilterOption. (@r7kamura)

Bug fixes

#1005: Flag break in with_lock for Rails/TransactionExitStatement. (@splattael)

#997: Fix to Allow NotNullColumn to work with method calls and variables. (@fidalgo)

#989: Fix Rails/FilePath to detect offenses from complex string interpolation. (@r7kamura)

#1010: Fix Rails/ThreeStateBooleanColumn for dynamic tables/columns. (@fatkodima)

#1008: Fix UniqueValidationWithoutIndex to not detect offenses when a validation specifies uniqueness: false. (@samrjenkins)

Changes

#1011: Add *_create_active_storage_variant_records.active_storage.rb to Rails/CreateTableWithTimestamps exclude file list. (@tka5)

#995: Check for or method in Rails/FindEach cop. (@masato-bkn)

#1019: Change db migration file pattern so that it supports multiple db. (@r7kamura)

#986: (Breaking) Drop Ruby 2.6 support. (@koic)

#992: Exclude app/assets/**/* by default. (@r7kamura)

#1014: Make Lint/RedundantSafeNavigation aware of presence and present? methods. (@koic)

#1007: Support flash.now for Rails/I18nLocaleTexts. (@fatkodima)

2.19.1

Bug fixes

#979: Fix an error for Rails/ThreeStateBooleanColumn when using t.boolean in drop_table. (@koic)

2.19.0

New features

#337: Add new Rails/ThreeStateBooleanColumn cop. (@fatkodima)

#45: Make Rails/Delegate aware of self. (@koic)

Bug fixes

#934: Fix a false negative for Rails/Output when print methods without arguments. (@koic)

#99: Fix a false positive for Rails/HttpPositionalArguments when using include Rack::Test::Methods. (@koic)

#501: Fix a false positive for Rails/OutputSafety when using html_safe for I18n methods. (@koic)

#860: Fix a false positive for Rails/Pluck when using regexp literal key for String#[]. (@koic)

#938: Fix an error for Rails/WhereNotWithMultipleConditions when using where.not.lt(condition) as a Mongoid API'. (@koic)

#941: Remove redundant config for Style/InverseMethods. (@koic)

Changes

#299: Add autocorrection for Rails/ReflectionClassName. (@tejasbubane)

#34: Allow CreateTableWithTimestamps when using id: false and not include timestamps. (@koic)

#694: Mark Rails/FindEach as unsafe. (@koic)

#940: Mark Rails/ResponseParsedBody as unsafe. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ rubocop (1.51.0 → 1.57.2) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ i18n (indirect, 1.12.0 → 1.14.1) · Repo · Changelog

Release Notes

1.14.1

Included in this release

Simplify the "Translation missing" message when default is an empty Array by @amatsuda in #662

Maintenance stuff

Skip CIing on jruby against Rails 5.2 by @amatsuda in #664

A fix for failing CI against edge Rails by @amatsuda in #663

Add documentation hint for fallback values by @mark-a in #659

CI against Ruby 3.2 by @amatsuda in #665

Fix build warnings in the CI by using actions/checkout@v3 by @amatsuda in #666

Thanks to @amatsuda for these PRs!

New Contributors

@mark-a made their first contribution in #659

Full Changelog: v1.14.0...v1.14.1

1.14.0

What's Changed

fix LazyLoadable#available_locales duplicating locales by @ccutrer in #655

Add more helpful translation error when :default option is provided. by @Nerian in #654

Fix I18n::Locale::Fallbacks not initializing itself on Ruby 3 by @yheuhtozr in #653

Fix I18n.t when locale contains separator by @tubaxenor in #656

This reverts a change from #651, that was released in v1.13.0

New Contributors

@ccutrer made their first contribution in #655

@Nerian made their first contribution in #654

@yheuhtozr made their first contribution in #653

@tubaxenor made their first contribution in #656

Full Changelog: v1.13.0...v1.14.0

1.13.0

What's Changed

Fix symbol resolving with pluralization by @movermeyer in #636

Updating DEFAULT_APPROXIMATIONS with capitalised German Eszett character for consistency by @lucapericlp in #627

Fix load_path example in README.md by @nickcampbell18 in #642

Add support for meridian indicators on Date objects by @movermeyer in #640

Make translations loading thread-safe by @mensfeld in #644

Get closer to full CLDR pluralization support by @movermeyer in #634

Allow passing scope argument to exists? by @misdoro in #647

Revert #503 changes for Backend::Base by @movermeyer in #637

Properly stub constants by @fatkodima in #650

Optimize I18n.t by @fatkodima in #651

Return same string object when no interpolations were made by @fatkodima in #649

New Contributors

@lucapericlp made their first contribution in #627

@nickcampbell18 made their first contribution in #642

@mensfeld made their first contribution in #644

@misdoro made their first contribution in #647

Full Changelog: v1.12.0...v1.13.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ minitest (indirect, 5.18.0 → 5.20.0) · Repo · Changelog

Release Notes

5.20.0 (from changelog)

1 minor enhancement:

Optionally allow autorun exit hook to remain active in forked child. (casperisfine)

5.19.0 (from changelog)

2 minor enhancements:

Add metadata lazy accessor to Runnable / Result. (matteeyah)

Only load minitest/unit (aka ancient MiniTest compatibility layer) if ENV

1 bug fix:

Minitest::TestTask enthusiastically added itself to default. (ParadoxV5)

5.18.1 (from changelog)

3 bug fixes:

Avoid extra string allocations when filtering tests. (tenderlove)

Only mention deprecated ENV if it is an integer string.

Push up test_order to Minitest::Runnable to fix minitest/hell. (koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parser (indirect, 3.2.2.1 → 3.2.2.4) · Repo · Changelog

Release Notes

3.2.2.4 (from changelog)

API modifications:

bump Racc to 1.7.1 (#930) (Koichi ITO)

Bugs fixed:

Fix an error for flip-flop with beginless or endless ranges (#946) (Koichi ITO)

3.2.2.3 (from changelog)

API modifications:

Add Racc to runtime dependencies (#929) (Koichi ITO)

3.2.2.2 (from changelog)

API modifications:

bump racc to 1.7.0 (#928) (Ilya Bylich)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rack (indirect, 2.2.6.4 → 2.2.8) · Repo · Changelog

Release Notes

2.2.7

What's Changed

Correct the year number in the changelog by @kimulab in #2015

Support underscore in host names for Rack 2.2 (Fixes #2070) by @jeremyevans in #2071

New Contributors

@kimulab made their first contribution in #2015

Full Changelog: v2.2.6.4...v2.2.7

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ regexp_parser (indirect, 2.8.0 → 2.8.2) · Repo · Changelog

Release Notes

2.8.2 (from changelog)

Fixed

handle a corner case where parsing redundant number escapes raised an error

e.g. parse(/\99/), which in Ruby is a valid Regexp that matches 99

thanks to Markus Schirp for the report

2.8.1 (from changelog)

Fixed

support for extpict unicode property, added in Ruby 2.6

support for 10 unicode script/block properties added in Ruby 3.2

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rexml (indirect, 3.2.5 → 3.2.6) · Repo · Changelog

Release Notes

3.2.6

Improvements

Required Ruby 2.5 or later explicitly.
GH-69
[Patch by Ivo Anjo]

Added documentation for maintenance cycle.
GH-71
[Patch by Ivo Anjo]

Added tutorial.
GH-77
GH-78
[Patch by Burdette Lamar]

Improved performance and memory usage.
GH-94
[Patch by fatkodima]

REXML::Parsers::XPathParser#abbreviate: Added support for
function arguments.
GH-95
[Reported by pulver]

REXML::Parsers::XPathParser#abbreviate: Added support for string
literal that contains double-quote.
GH-96
[Patch by pulver]

REXML::Parsers::XPathParser#abbreviate: Added missing / to
:descendant_or_self/:self/:parent.
GH-97
[Reported by pulver]

REXML::Parsers::XPathParser#abbreviate: Added support for more patterns.
GH-97
[Reported by pulver]

Fixes

Fixed a typo in NEWS.
GH-72
[Patch by Spencer Goodman]

Fixed a typo in NEWS.
GH-75
[Patch by Andrew Bromwich]

Fixed documents.
GH-87
[Patch by Alexander Ilyin]

Fixed a bug that Attriute convert ' and ' even when
attribute_quote: :quote is used.
GH-92
[Reported by Edouard Brière]

Fixed links in tutorial.
GH-99
[Patch by gemmaro]

Thanks

Ivo Anjo

Spencer Goodman

Andrew Bromwich

Burdette Lamar

Alexander Ilyin

Edouard Brière

fatkodima

pulver

gemmaro

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rubocop-ast (indirect, 1.28.1 → 1.30.0) · Repo · Changelog

Release Notes

1.30.0 (from changelog)

New features

#270: Add BlockNode#{first,last}_argument helpers. (@sambostock)

1.29.0 (from changelog)

#262: Introduce RuboCop::Ast::MethodDispatchNode#selector. (@gsamokovarov)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ unicode-display_width (indirect, 2.4.2 → 2.5.0) · Repo · Changelog

Release Notes

2.5.0 (from changelog)

Unicode 15.1

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ zeitwerk (indirect, 2.6.7 → 2.6.12) · Repo · Changelog

Release Notes

2.6.12 (from changelog)

Maintenance release with some internal polishing.

2.6.11 (from changelog)

Let on_load callbacks for implicit namespaces autoload other implicit namespaces.

2.6.10 (from changelog)

Improve validation of the values returned by the inflector's camelize.

2.6.9 (from changelog)

Given a path as a string or Pathname object, Zeitwerk::Loader#cpath_expected_at returns a string with the corresponding expected constant path.

Some examples, assuming that app/models is a root directory:
loader.cpath_expected_at("app/models")                  # => "Object"
loader.cpath_expected_at("app/models/user.rb")          # => "User"
loader.cpath_expected_at("app/models/hotel")            # => "Hotel"
loader.cpath_expected_at("app/models/hotel/billing.rb") # => "Hotel::Billing"
This method returns nil for some input like ignored files, and may raise errors too. Please check its documentation for further details.
Zeitwerk::Loader#load_file raises with a more informative error if given a hidden file or directory.

Zeitwerk::Loader#eager_load_dir does nothing if the argument is a hidden file or directory. This is coherent with its existing behavior for eager load exclusions and ignored paths. Before, that kind of argument would result in a non-deliberate NameError.

Documentation improvements.

2.6.8 (from changelog)

The new Zeitwerk::Loader.for_gem_extension gives you a loader configured according to the conventions of a gem extension.

Please check its documentation for further details.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

🆕 language_server-protocol (added, 3.17.0.3)

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

depfu · 2023-12-17T03:13:17Z

Closed in favor of #360.

Update rubocop-rails to version 2.22.2

e1beed5

depfu bot added the depfu label Nov 20, 2023

depfu bot mentioned this pull request Nov 20, 2023

Update rubocop-rails 2.18.0 → 2.22.1 (minor) #356

Closed

depfu bot closed this Dec 17, 2023

depfu bot deleted the depfu/update/rubocop-rails-2.22.2 branch December 17, 2023 03:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update rubocop-rails 2.18.0 → 2.22.2 (minor) #357

Update rubocop-rails 2.18.0 → 2.22.2 (minor) #357

depfu bot commented Nov 20, 2023

depfu bot commented Dec 17, 2023

Update rubocop-rails 2.18.0 → 2.22.2 (minor) #357

Update rubocop-rails 2.18.0 → 2.22.2 (minor) #357

Conversation

depfu bot commented Nov 20, 2023

What changed?

✳️ rubocop-rails (2.18.0 → 2.22.2) · Repo · Changelog

Bug fixes

Changes

Bug fixes

New features

Bug fixes

Changes

Bug fixes

Bug fixes

New features

Bug fixes

Changes

Bug fixes

Bug fixes

New features

Bug fixes

Changes

Bug fixes

New features

Bug fixes

Changes

✳️ rubocop (1.51.0 → 1.57.2) · Repo · Changelog

↗️ i18n (indirect, 1.12.0 → 1.14.1) · Repo · Changelog

Included in this release

Maintenance stuff

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

↗️ minitest (indirect, 5.18.0 → 5.20.0) · Repo · Changelog

5.20.0 (from changelog)

5.19.0 (from changelog)

5.18.1 (from changelog)

↗️ parser (indirect, 3.2.2.1 → 3.2.2.4) · Repo · Changelog

3.2.2.4 (from changelog)

3.2.2.3 (from changelog)

3.2.2.2 (from changelog)

↗️ rack (indirect, 2.2.6.4 → 2.2.8) · Repo · Changelog

What's Changed

New Contributors

↗️ regexp_parser (indirect, 2.8.0 → 2.8.2) · Repo · Changelog

2.8.2 (from changelog)

2.8.1 (from changelog)

Fixed

↗️ rexml (indirect, 3.2.5 → 3.2.6) · Repo · Changelog

Improvements

Fixes

Thanks

↗️ rubocop-ast (indirect, 1.28.1 → 1.30.0) · Repo · Changelog

1.30.0 (from changelog)

1.29.0 (from changelog)

↗️ unicode-display_width (indirect, 2.4.2 → 2.5.0) · Repo · Changelog

2.5.0 (from changelog)

↗️ zeitwerk (indirect, 2.6.7 → 2.6.12) · Repo · Changelog

2.6.12 (from changelog)

2.6.11 (from changelog)

2.6.10 (from changelog)

2.6.9 (from changelog)

2.6.8 (from changelog)

🆕 language_server-protocol (added, 3.17.0.3)

depfu bot commented Dec 17, 2023