DPL-753-2 process new QC fields from TOL #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
emrojo
approved these changes
Jul 14, 2023
tol_lab_share/config/defaults.py
Outdated
|
|
||
| EBI_TAXONOMY_URL = "https://www.ebi.ac.uk/ena/taxonomy/rest/tax-id" | ||
|
|
||
| # Options: 'json' or 'binary' | ||
| SELECTED_ENCODER_FOR_FEEDBACK_MESSAGE = "binary" | ||
|
|
||
| # Validate SSL certificate chain when connecting to https | ||
| CERTIFICATES_VALIDATION_ENABLED = True | ||
| CERTIFICATES_VALIDATION_ENABLED = False |
There was a problem hiding this comment.
This one was for testing locally, we can roll it back to True to test it in github actions
Comment on lines
+229
to
+240
| def requests(self, position: int) -> TractionQcMessageRequestInterface: | ||
| """Returns the request at position position from this message. If there is no requesrt there it | ||
| will create a new instance and return it. | ||
| Parameters: | ||
| position (int) position that we want to return | ||
| Returns: | ||
| OutputTractionMessageRequest with the request required | ||
| """ | ||
| if position not in self._requests: | ||
| self._requests[position] = TractionQcMessageRequest() | ||
|
|
||
| return self._requests[position] |
There was a problem hiding this comment.
Is this requests from the new qc result message sent to traction?
|
From Steve - Update from meeting 27/07: date_required_by and reason_for_priority are no longer required and can be removed from this schema. priority_level is not a qc_result attribute but should be moved to sample. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request:
In tol_lab_share project, add new message properties for each of the new qc fields and add them as properties for a sample with no validation apart from checking is a string (check how it is with CommonName) (in message_properties/sample.py)
Create new message for qc_results traction to include the new fields in the payload we send
Add the new properties into the qc results traction message that we will send (in message_properties/labware.py). We need also to add the attributes to qc results traction message interface to add the new fields
Modify the CreateLabwareProcessor to send the message to qc_results traction endpoint if the creation of samples was successful in previous step
In case of errror while sending qc_result request, append the errors to the feedback message
Add the required tests.