Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dpl 753 2 process qc fields #42

Merged
merged 8 commits into from
Sep 13, 2023
Merged

Dpl 753 2 process qc fields #42

merged 8 commits into from
Sep 13, 2023

Conversation

Sangeetha-Bheeman
Copy link
Contributor

@Sangeetha-Bheeman Sangeetha-Bheeman commented Aug 22, 2023 •
edited
Loading

Closes #

Changes proposed in this pull request:

  • Made changes to accept country of origin from TOL as case-insensitive and then compare it with insdc config.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check version

stevieing
stevieing requested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@stevieing stevieing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ok. Just need to remove the line from automated_release action.

.github/workflows/automated_release.yml Outdated Show resolved Hide resolved
@Sangeetha-Bheeman Sangeetha-Bheeman merged commit a1e3bd1 into develop Sep 13, 2023
4 checks passed
@sdjmchattie sdjmchattie deleted the dpl-753-2-process-qc-fields branch June 7, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevieing stevieing stevieing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sangeetha-Bheeman @stevieing