-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2003 from sanger/Y24-344-qc-result-upload-fetch-m…
…igration Y24-344 - QC Results Upload migration to fetch.
- Loading branch information
Showing
6 changed files
with
92 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import fs from 'fs' | ||
| import BaseFactory from './BaseFactory.js' | ||
|
|
||
| const defaultCsv = fs.readFileSync('./tests/data/csv/qc-results-upload.csv', 'utf8') | ||
| /* | ||
| * Factory for creating a QcResultUploadResponse object | ||
| * @returns a base factory object with the QcResultUpload data | ||
| */ | ||
| const PrinterFactory = (csv = defaultCsv, used_by = 'extraction') => { | ||
| const data = { | ||
| data: { | ||
| id: '69', | ||
| type: 'qc_results_uploads', | ||
| links: { | ||
| self: 'http://localhost:3100/v1/qc_results_uploads/69', | ||
| }, | ||
| attributes: { | ||
| csv_data: csv, | ||
| used_by, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| return { ...BaseFactory(data) } | ||
| } | ||
|
|
||
| export default PrinterFactory |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,73 +1,64 @@ | ||
| import fs from 'fs' | ||
| import { createQcResultsUploadResource } from '@/services/traction/QcResultsUpload' | ||
| import { createQcResultsUploadResource } from '@/services/traction/QcResultsUpload.js' | ||
| import QcResultUploadFactory from '@tests/factories/QcResultUploadFactory.js' | ||
|
|
||
| const csv = fs.readFileSync('./tests/data/csv/qc-results-upload.csv', 'utf8') | ||
| const used_by = 'extraction' | ||
| const QcResultsUploadFactory = QcResultUploadFactory(csv, used_by) | ||
|
|
||
| describe('QcResultsUpload', () => { | ||
| describe('#createQcResultsUploadResource', () => { | ||
| const csv = fs.readFileSync('./tests/data/csv/pacbio-missing-source.csv', 'utf8') | ||
|
|
||
| const usedBySelected = 'extraction' | ||
|
|
||
| const createdReceptionResponse = { | ||
| status: 201, | ||
| statusText: 'Created', | ||
| data: { | ||
| id: '69', | ||
| type: 'qc_results_uploads', | ||
| links: { | ||
| self: 'http://localhost:3100/v1/qc_results_uploads/69', | ||
| }, | ||
| attributes: { | ||
| csv_data: csv, | ||
| used_by: usedBySelected, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| const createQcResultsUploadRequest = vi.fn() | ||
|
|
||
| it('successfully', async () => { | ||
| createQcResultsUploadRequest.mockResolvedValue(createdReceptionResponse) | ||
| createQcResultsUploadRequest.mockResolvedValue(QcResultsUploadFactory.responses.fetch) | ||
|
|
||
| const response = await createQcResultsUploadResource(createQcResultsUploadRequest, { | ||
| csv, | ||
| usedBySelected, | ||
| usedBySelected: used_by, | ||
| }) | ||
|
|
||
| expect(response).toEqual(createdReceptionResponse.data) | ||
| expect(response).toEqual({ | ||
| success: true, | ||
| ...QcResultsUploadFactory.content, | ||
| errors: [], | ||
| }) | ||
| }) | ||
|
|
||
| it('generates a valid payload', async () => { | ||
| createQcResultsUploadRequest.mockResolvedValue(createdReceptionResponse) | ||
| createQcResultsUploadRequest.mockResolvedValue(QcResultsUploadFactory.responses.fetch) | ||
|
|
||
| await createQcResultsUploadResource(createQcResultsUploadRequest, { csv, usedBySelected }) | ||
| await createQcResultsUploadResource(createQcResultsUploadRequest, { | ||
| csv, | ||
| usedBySelected: used_by, | ||
| }) | ||
|
|
||
| expect(createQcResultsUploadRequest).toHaveBeenCalledWith({ | ||
| data: { | ||
| data: { | ||
| type: 'qc_results_uploads', | ||
| attributes: { | ||
| csv_data: csv, | ||
| used_by: usedBySelected, | ||
| used_by: used_by, | ||
| }, | ||
| }, | ||
| }, | ||
| }) | ||
| }) | ||
|
|
||
| it('when the QcResultsUpload could not be created', async () => { | ||
| const failedResponse = { | ||
| status: 422, | ||
| statusText: 'Record not found', | ||
| data: { | ||
| errors: [{ title: 'error1', detail: 'There was an error.' }], | ||
| }, | ||
| } | ||
|
|
||
| createQcResultsUploadRequest.mockRejectedValue({ response: failedResponse }) | ||
| createQcResultsUploadRequest.mockRejectedValue('There was an error') | ||
|
|
||
| expect( | ||
| createQcResultsUploadResource(createQcResultsUploadRequest, { csv, usedBySelected }), | ||
| ).rejects.toThrow('error1 There was an error.') | ||
| await createQcResultsUploadResource(createQcResultsUploadRequest, { | ||
| csv, | ||
| usedBySelected: used_by, | ||
| }), | ||
| ).toEqual({ | ||
| success: false, | ||
| data: {}, | ||
| errors: 'There was an error', | ||
| }) | ||
| }) | ||
| }) | ||
| }) |