fix(visual-editing): prevent snapshot overfetching #2615
Merged
+24
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
stipsan
approved these changes
Feb 5, 2025
| @@ -323,6 +330,7 @@ export const Overlays: FunctionComponent<{ | |||
| }, [overlayEnabled]) | |||
|
|
|||
| const documentIds = useMemo(() => { | |||
| console.log('recalc documentIds') | |||
There was a problem hiding this comment.
Suggested change
| console.log('recalc documentIds') |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like 74fdcdd introduced some changes in the
DocumentReportercomponent which removed the unique document ID check.This is causing documents to be unobserved/observed on every render—such as hovering on/off overlay—even if the IDs haven't changed, which in turn triggers a request to Presentation to fetch new document snapshots for every document on the page. This can result in hundreds of requests on each interaction. See video below.
This PR reverts that change, and should fix this issue.
Kapture.2025-02-05.at.01.49.06.mp4