Fixing code updated to avoid issue SEC-1606

sannies · Apr 3, 2011 · 3abd4ff · 3abd4ff
1 parent 3cb8466
commit 3abd4ff
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/...urity-saml/saml2-core/src/main/java/org/springframework/security/saml/SAMLEntryPoint.java b/...urity-saml/saml2-core/src/main/java/org/springframework/security/saml/SAMLEntryPoint.java
@@ -182,8 +182,7 @@ public void commence(HttpServletRequest request, HttpServletResponse response, A
     protected void initializeSelection(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
 
         logger.debug("Initializing IDP selection");
-        response.setContentType("text/html");
-        request.getRequestDispatcher(idpSelectionPath).include(request, response);
+        request.getRequestDispatcher(idpSelectionPath).forward(request, response);
 
     }
 

diff --git a/...y-saml/saml2-core/src/test/java/org/springframework/security/saml/SAMLEntryPointTest.java b/...y-saml/saml2-core/src/test/java/org/springframework/security/saml/SAMLEntryPointTest.java
@@ -130,8 +130,7 @@ public void testIDPSelection() throws Exception {
         expect(request.getRequestDispatcher("/selectIDP")).andReturn(dispatcher);
         expect(request.getHeader("Accept")).andReturn("text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8");
         expect(request.getHeader(org.springframework.security.saml.SAMLConstants.PAOS_HTTP_HEADER)).andReturn(null);
-        response.setContentType("text/html");
-        dispatcher.include(request, response);
+        dispatcher.forward(request, response);
 
         replay(dispatcher);
         replayMock();