Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cflags include to use pkg-config if include directory is different then default /usr/include #86

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rkalkani
Copy link

We are using think package in an embedded rootfs and we are not able to build this package within Yocto recipe since the includes are from different.

We can update the build to also respect the pkg-config value on Linux.

rkalkani added 3 commits July 16, 2018 18:39
Update cflags include to use pkg-config if include directory is different then default /usr/include
…use-pkg-config

Update cflags include to use pkg-config
@rkalkani
Copy link
Author

@sebastianarena Hi, We love your package and are thankful for your work. Will you please have a look at PR. I did not find the contribution guide so not sure If I opened PR correctly or not. Let me know your feedback on PR, and what we need to update to have these changes on upstream instead of managing our own fork.

We are using your library it in an embedded system. The current hardcoded include path does not work when doing the cross-platform build. We could either add extra include flag to get right include path from pkg-config OR replace fix include path with pkg-config. I think pkg-config is nowadays available on most of the distros.

@santigimeno
Copy link
Owner

@rkalkani sorry this PR fell through the cracks. Let me take a look at it and if it's fine I'll merge it.

@bkchr
Copy link

bkchr commented Mar 13, 2021

@santigimeno any update on this? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants