-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Metric Registry #4428
Merged
Merged
Create Metric Registry #4428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanIvanoff
force-pushed
the
start-metrics-registry
branch
2 times, most recently
from
October 21, 2024 09:21
b05c3e8
to
54c13ae
Compare
IvanIvanoff
force-pushed
the
start-metrics-registry
branch
6 times, most recently
from
October 31, 2024 16:02
bb3a8a2
to
f58eaed
Compare
IvanIvanoff
force-pushed
the
start-metrics-registry
branch
from
November 5, 2024 13:17
3544402
to
617c25f
Compare
IvanIvanoff
force-pushed
the
start-metrics-registry
branch
from
November 7, 2024 14:52
89fb71a
to
de50a06
Compare
tspenov
reviewed
Nov 8, 2024
lib/sanbase_web/live/metric_registry/metric_registry_form_live.ex
Outdated
Show resolved
Hide resolved
…ored_terms function
IvanIvanoff
force-pushed
the
start-metrics-registry
branch
from
November 8, 2024 11:25
c4b4085
to
06a45ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Create a Metric Registry that is replacing the static JSON files used to define Clickhouse metrics.
The old way
Before, to expose a clickhouse metric through the API, a JSON map describing the metric needed to be added to a JSON file here in the repository, looking like this:
The new way
Now the metrics definitions are moved to Postgres and a web interface is exposed to edit/create metrics.
The WEB interface is accessed through VPN and after credentials are obtained.
The endpoints are:
Showing metric details
Show all the details for a metric. The same fields as in the JSON file are exposed. Some of the fields are slightly renamed (aggregation -> default aggregation) or split (
min_plan
is not a map, but there are 2 fields:Sanbase Min Plan
andSanapi Min Plan
)Editing metrics
The metric information can be edited through the Web interface.
A big benefit of the web interface compared to the JSON files is that the changes are validated in real-time.
Ticket
Checklist: