Encode/decode social volume words to/from www form #4438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanIvanoff
force-pushed
the
encode-decode-social-volume-words
branch
from
2dc4667
to
32e13a3
Compare
Otherwise words like $43,000 are considered as 2 words as the comma is used for a separator. Encoding on our end and metricshub decoding on its end will fix this problem.
IvanIvanoff
force-pushed
the
encode-decode-social-volume-words
branch
from
32e13a3
to
e09b2a6
Compare
tspenov
reviewed
Oct 22, 2024
| "2024-09-28T00:00:00Z" => 373, | ||
| "2024-09-29T00:00:00Z" => 487, | ||
| "2024-09-30T00:00:00Z" => 323 | ||
| }, | ||
| "eth or nft" => %{ | ||
| URI.encode_www_form("eth or nft") => %{ |
There was a problem hiding this comment.
We return from the API the keys as www-form-urlencoded strings ? Does this mean that the frontend should change their logic also ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Otherwise words like $43,000 are considered as 2 words as the comma is
used for a separator. Encoding on our end and metricshub decoding on
its end will fix this problem.
This needs to be deployed together with the metricshub changes.
Ticket
Checklist: