Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve metric to module #4463

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Improve metric to module #4463

merged 2 commits into from
Nov 15, 2024

Conversation

IvanIvanoff
Copy link
Member

@IvanIvanoff IvanIvanoff commented Nov 14, 2024 •
edited
Loading

Changes

  • Simplify Sanbase.Metric metric to module mapping
  • Add :prefers option to Sanbase.Metric's get_module/2

Ticket

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have tried to find clearer solution before commenting hard-to-understand parts of code
  • I have added tests that prove my fix is effective or that my feature works

@IvanIvanoff IvanIvanoff changed the title improve metric to module Improve metric to module Nov 14, 2024
@IvanIvanoff IvanIvanoff merged commit 34bec51 into master Nov 15, 2024
2 checks passed
@IvanIvanoff IvanIvanoff deleted the improve-metric-to-module branch November 15, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IvanIvanoff