Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cleanup and Move Python dependencies to virtual environment #43

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

marcelmamula
Copy link

Proposal for sap_hana_ha scenario before working on others

Description

  • Remove packages that are not needed
  • Install pip modules into virtual environment
  • Execute sap_launchpad with virtual environment
  • Create new python inputs in extravars for python version selection (ansible interpreter is Control node specific and cannot be used)

@marcelmamula marcelmamula self-assigned this Dec 5, 2024
Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the task logic successfully in a dedicated playbook just for sap_launchpad.
This worked fine for a new download as well as being idempotent in a re-run.

👍

Would it make sense to clean up the venv afterwards? Assuming that the venv is only needed for the sap_launchpad execution on the software target host, it could be nice to remove it afterwards. Similar to the cleanup of other temporary config like temp dirs or ssh keys.

@marcelmamula
Copy link
Author

@ja9fuchs Thank you for suggestion! I have replaced it with tempfile and delete it afterwards

@ja9fuchs
Copy link
Contributor

ja9fuchs commented Dec 9, 2024

Tested the tempfile change - working nicely. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants