Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_ha_pacemaker_cluster: JAVA HA scenarios and complete refactor #882

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

marcelmamula
Copy link
Contributor

@marcelmamula marcelmamula commented Oct 25, 2024

Purpose

  1. Add SAP Netweaver SCS/ERS cluster scenario
  2. Simplify variables to align with SAP naming (ASCS is ABAP SCS, there is no reason to specify ABAP ASCS as it is contained in its name).

Changes

  1. Added SCS/ERS ENSA1 and ENSA2 Classic and Simple Mount (same code as ASCS since there are no differences in config itself)

  2. Refactor of all variables with *nwas_abap_* to *nwas_* to work with java and to make more sense in regards to SAP naming.

    • *nwas_abap_* is retained only as part of sap_ha_pacemaker_cluster_host_type
nwas_abap_ascs_ers
nwas_abap_pas_aas
nwas_java_scs_ers
  1. Refactor of private variables to remove all calculations from defaults and vars. All of them are moved to include_vars tasks separately so we can do

    • Use backwards compatible variables until they are removed
    • Use user variables if specified
    • Default back to empty string or calculated variable of user did not specify.
  2. New asserts to cover mandatory variables, that were mandatory before, but never validated with assert.

  3. Added variables for future proofing PAS/AAS, but not actual cluster setup code.

  4. argument_spec and readme updated with variables that were not listed before (health checks, VIP, etc.)

Tested and validated on

Operating system:

  • SUSE Linux Enterprise Server for SAP applications 15 SP5
  • SUSE Linux Enterprise Server for SAP applications 15 SP6

Platforms:

  • AWS
  • Azure
  • Google Cloud

Tested scenarios:

  • SAP HANA HA
  • SAP ASCS/ERS
  • SAP SCS/ERS

Added SCS/ERS Classic and Simple Mount
Refactor of nwas_abap to work with java
Refactor of private variables
Backwards compatibility for nwas_abap
@marcelmamula marcelmamula added the enhancement New feature or request label Oct 25, 2024
@marcelmamula marcelmamula self-assigned this Oct 25, 2024
@marcelmamula marcelmamula marked this pull request as ready for review November 7, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant