sap_ha_pacemaker_cluster: Regressions in Dev version for vmware/bare-metal deployments #923
Conversation
…luster_fence_agent_packages_platform not defined (this is case for on-prem/bare metal)
…o prevent errors when setting corosync totem errors on bare metal RHEL
There was a problem hiding this comment.
Good catch!
Before we proceed, @marcelmamula do you think it makes sense to add this to vars/main.yml to make it consistent with e.g. __sap_ha_pacemaker_cluster_platform_extra_packages: [] in there already?
|
@rob0d I agree with @ja9fuchs that it would be better to remove current change with __sap_ha_pacemaker_cluster_platform_extra_packages: []
__sap_ha_pacemaker_cluster_fence_agent_packages_platform: [] |
…kages platform to prevent errors
|
Yes. That makes more sense. I didn't want to define a default empty value as I wasn't sure if you rely on "is defined" somewhere else in the code which I can't test. |
We rather not rely on non-existence of vars. :) Did you push the update already? It's not showing up... |
|
@ja9fuchs sorry, forgot to press the button. It's there now :) |
@marcelmamula @ja9fuchs
I've found a few regressions in 1.5.0 (or current dev branch) which broke the role when executing on bare metal or vmware systems. I see most changes which caused this are related to cloud systems. This PR should fix both known errors (another error has been fixed in the current dev branch).