Fix lints

internal/api/api.go

@@ -23,11 +23,12 @@ import (
 	"net/http"
 
 	"github.com/gorilla/mux"
+	"github.com/sapcc/go-bits/httpapi"
+	"github.com/sapcc/go-bits/respondwith"
+
 	"github.com/sapcc/backup-tools/internal/backup"
 	"github.com/sapcc/backup-tools/internal/core"
 	"github.com/sapcc/backup-tools/internal/restore"
-	"github.com/sapcc/go-bits/httpapi"
-	"github.com/sapcc/go-bits/respondwith"
 )
 
 // API contains the HTTP request handlers for the backup-server.

internal/backup/backup.go

@@ -31,8 +31,9 @@ import (
 	"github.com/kballard/go-shellquote"
 	"github.com/majewsky/schwift"
 	"github.com/prometheus/client_golang/prometheus"
-	"github.com/sapcc/backup-tools/internal/core"
 	"github.com/sapcc/go-bits/logg"
+
+	"github.com/sapcc/backup-tools/internal/core"
 )
 
 var backupLastSuccessGauge = prometheus.NewGauge(prometheus.GaugeOpts{
@@ -68,7 +69,7 @@ func Create(cfg *core.Configuration, reason string) (nowTime time.Time, returned
 
 	//enumerate databases that need to be backed up
 	query := `SELECT datname FROM pg_database WHERE datname !~ '^template|^postgres$'`
-	cmd := exec.Command("psql", cfg.ArgsForPsql("-t", "-c", query)...)
+	cmd := exec.Command("psql", cfg.ArgsForPsql("-t", "-c", query)...) //nolint:gosec // input is user supplied and self executed
 	logg.Info(">> " + shellquote.Join(cmd.Args...))
 	cmd.Stderr = os.Stderr
 	output, err := cmd.Output()
@@ -94,7 +95,7 @@ func Create(cfg *core.Configuration, reason string) (nowTime time.Time, returned
 		errChan := make(chan error, 1) //must be buffered to ensure that `pipewriter.Close()` runs immediately
 		go func() {
 			defer pipeWriter.Close()
-			cmd := exec.CommandContext(ctx, "pg_dump",
+			cmd := exec.CommandContext(ctx, "pg_dump", //nolint:gosec // input is user supplied and self executed
 				"-h", cfg.PgHostname, "-U", cfg.PgUsername, //NOTE: PGPASSWORD comes via inherited env variable
 				"-c", "--if-exist", "-C", "-Z", "5", databaseName)
 			logg.Info(">> " + shellquote.Join(cmd.Args...))

internal/backup/timestamp.go

@@ -26,6 +26,7 @@ import (
 	"time"
 
 	"github.com/majewsky/schwift"
+
 	"github.com/sapcc/backup-tools/internal/core"
 )
 

internal/restore/restore.go

@@ -25,8 +25,9 @@ import (
 	"os/exec"
 
 	"github.com/kballard/go-shellquote"
-	"github.com/sapcc/backup-tools/internal/core"
 	"github.com/sapcc/go-bits/logg"
+
+	"github.com/sapcc/backup-tools/internal/core"
 )
 
 // Restore downloads and restores this backup into the Postgres.
@@ -44,7 +45,7 @@ func (bkp RestorableBackup) Restore(cfg *core.Configuration) error {
 
 	//playback dumps
 	for _, filePath := range filePaths {
-		cmd := exec.Command("psql", cfg.ArgsForPsql("-a", "-f", filePath)...)
+		cmd := exec.Command("psql", cfg.ArgsForPsql("-a", "-f", filePath)...) //nolint:gosec // input is user supplied and self executed
 		logg.Info(">> " + shellquote.Join(cmd.Args...))
 		cmd.Stdout = os.Stdout
 		cmd.Stderr = os.Stderr

internal/restore/swift.go

@@ -137,7 +137,7 @@ func (bkp RestorableBackup) downloadOneFile(dirPath, databaseName string, cfg *c
 		return "", err
 	}
 	defer writer.Close()
-	_, err = io.Copy(writer, gzipReader)
+	_, err = io.Copy(writer, gzipReader) //nolint:gosec // the archive is created by us and we must extract it completely
 	if err != nil {
 		return "", fmt.Errorf("could not ungzip %s: %w", obj.Name(), err)
 	}