retry timestamp read/write in Swift #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on a first draft by Sandro that I cleaned up by moving the retry into a separate function.
SuperSandro2000
approved these changes
Jan 9, 2024
| if err != nil { | ||
| var str string | ||
| err := retryUpToThreeTimes(func() error { | ||
| var err error |
There was a problem hiding this comment.
Is it a thing in go to name this err2 to reduce confusion?
There was a problem hiding this comment.
I have sometimes used alternative variable names if I need to be able to access the older error within the same scope. But in this case, I'd rather reuse the name in order to shadow the outer err. If we go with err2, there's a chance to accidentally reference the outer error when the inner error was meant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #89, see comments there.