plugins: simplify Nova flavor listing #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Nova microversion 2.61, flavors.ListDetail() includes the extra specs, so we can save a ton of work querying them one flavor at a time. Gophercloud already has support for this, too.
VoigtS
approved these changes
Oct 9, 2024
By increasing the Nova API microversion in the previous commit, the hypervisor "id" field has changed from a number to a UUID. We are not using this value anywhere, but whatever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Nova microversion 2.61, flavors.ListDetail() includes the extra specs, so we can save a ton of work querying them one flavor at a time. Gophercloud already has support for this, too.
Draft:
I have not tested this yet. Feel free to have a look at the implementation; I will test this in QA after my leave.I have now tested this. There was a minor bug caused by the microversion bump which is now fixed. Thetest-scan-capacityin qa-de-1 went from needing 787 API calls to just 59. Nice improvement.