-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and make php-parse a dev dependency #160
Conversation
ff21829
to
022bf63
Compare
022bf63
to
414febb
Compare
From my experience, it can avoid a lot of hassle to run PHP-CS-Fixer and PHPStan only with one PHP version, one TYPO3 version and one set of dependencies (highest vs. lowest) on CI as the results otherwise tend to vary somewhat. |
Actually I'm not a big fan of this but yes, it can become pretty complex. PHPStan itself does also have a special solution to support PHP 7.4. But i think... Time has come and PHP 7.4 support is ready to be dropped. I've now increased PHP requirement to 8.1 which should be fine for nearly everyone. |
I'm using this package in quite a few extensions that still support TYPO3 11LTS (and all PHP versions that TYPO3 11LTS supports, i.e., also PHP 7.4.). I'd like to be able to use the latest features and bugfixes and would appreciate either 7.4 support as long as TYPO3 11LTS is officially supported, or one last 7.4-compatible release before this PR gets merged. Thanks! 🙏 |
d47792c
to
d679148
Compare
d679148
to
cc153de
Compare
@oliverklee Here you go. I've now just adjusted some PHPCS rules so PHPCS is also happy when using PHP 7.4 |
@sascha-egerer Oh, thanks! ❤️ |
Closes #159